Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialogs - have a helper for better native dialog styles #171982

Merged
merged 3 commits into from
Jan 23, 2023
Merged

dialogs - have a helper for better native dialog styles #171982

merged 3 commits into from
Jan 23, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jan 23, 2023

No description provided.

@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Jan 23, 2023
@bpasero bpasero enabled auto-merge (squash) January 23, 2023 13:24
@bpasero bpasero merged commit 07b66c7 into main Jan 23, 2023
@bpasero bpasero deleted the ben/practical-pigeon branch January 23, 2023 13:29
@kim135797531
Copy link

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.75.1 (user setup), Korean Language
  • OS Version: Windows_NT x64 10.0.22621

Steps to Reproduce:

  1. Execute a heavy script in Python Jupyter
  2. appStalled message is appeared. (The window is not responding / You can reopen or close the window or keep waiting.)
  3. When I click the 'wait' button, VSCode will shutdown.
  4. Instead, when I click the 'close' button, then VScode wait the script.

I don't understand much code of vscode, but I think this commit is related with below (and commit of 07b66c7)

vscode/src/vs/platform/windows/electron-main/windowImpl.ts

Line 728 in fccbc48

localize({ key: 'close', comment: ['&& denotes a mnemonic'] }, "&&Close"),

I already checked the translation of Korean, and it was correct.
(https://github.com/microsoft/vscode-loc/blob/main/i18n/vscode-language-pack-ko/translations/main.i18n.json#L2385)

Thanks in advance!

@bpasero
Copy link
Member Author

bpasero commented Feb 14, 2023

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@kim135797531
Copy link

Oh, it seems to have been resolved in the insider version. (1.76.0-insider (user setup))
Sorry for the confusion caused. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bpasero @kim135797531 @alexr00 @VSCodeTriageBot